search

victorskl / yawsso

Yet Another AWS SSO - sync up AWS CLI v2 SSO login session to legacy CLI v1 credentials
MIT License
304 stars 27 forks source link

Quoted --ca-bundle option to handle paths that include whitesace #38

Closed bondsb closed 3 years ago

bondsb commented 3 years ago

The flag --ca-bundle works for paths with no whitespaces. This PR quotes the value passed to the flag in order to allow paths that include whitespace.

codecov[bot] commented 3 years ago

Codecov Report

Merging #38 into main will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          370       370           
=========================================
  Hits           370       370
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
yawsso/cli.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a959e46...abe8326. Read the comment docs.

victorskl commented 3 years ago

thanks for pr. lgtm. merging.