search

victorskl / yawsso

Yet Another AWS SSO - sync up AWS CLI v2 SSO login session to legacy CLI v1 credentials
MIT License
302 stars 26 forks source link

Only add --profile flag to aws sso command if profile passed #55

Closed bradsbrown closed 2 years ago

bradsbrown commented 2 years ago

This allows aws sso to otherwise read the AWS_PROFILE var.

Note: the only change here is to nest the addition to cmd_aws_sso_login inside the if args.profile: block.

codecov[bot] commented 2 years ago

Codecov Report

Merging #55 (3500da1) into main (0a89342) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          384       384           
=========================================
  Hits           384       384
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
yawsso/cli.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a89342...3500da1. Read the comment docs.

victorskl commented 2 years ago

Released. Pls upgrade pip install -U yawsso==0.7.2

Cheers!