search

victos / angular-opensource

angular opensource modules
MIT License
20 stars 21 forks source link

Feature: Automatically toPromise() Observables #18

Closed noskap closed 4 years ago

noskap commented 5 years ago

Currently [ngBusy] only works with Promises or an Observables' Subscription. I'm using a lot of async pipes in my code, so I never have to subscribe to Observables in the components. A workaround is calling toPromise() on an observable before passing it to ngBusy. It would be cleaner if ngBusy allowed us to use Observables from the start without having to toPromise them or manually subscribe

noskap commented 5 years ago

Feel free to use my fork as a base https://github.com/noskap/ng-busy-observable

jaufgang commented 4 years ago

@noskap, your ng-busy-observable is now out of date and not compatible with newer versions of angular. Instead of publishing your update as as separate package, perhaps consider making a PR to this package to support passing an observable?