victronenergy / dynamic-ess

MIT License
76 stars 5 forks source link

[Bug]: Price Graph one hour off after moving to "wintertime" #112

Open SimonYoungtree opened 8 months ago

SimonYoungtree commented 8 months ago

Contact Details

siempoot@gmail.com

VRM portal ID

c0619ab31cc4

Country / region

Netherlands (nl)

B max

42

TB max

6

FB max

6

TG max

16

FG max

16

Battery costs

0.025

Buy price

(p+0.13)*1.21+0.02

Sell price

(p+0.13)*1.21-0.02

feed-in possible

yes

feed-in control

None

Version

0.1.8 Venus OS 3.11

What happened?

The price graph and consequent calculation/acting are one hour off: the graph for 29-10-23 with highest prices at 6pm:

image

and Entsoe: highest prices at 17pm: (same on for example Zonneplan)

image

So discharging starts one hour too late:

image

It is as if the planning can't handle the extra hour we today on sunday. (time on GX device is correct, and so is the time shown on VRM)

When did it happen?

DD/MM/YYYY HH:MM

Relevant log output

No response

Screenshots

![DESCRIPTION](LINK.png)
dirkjanfaber commented 8 months ago

Fairly sure that it is indeed due to the extra hour of wintertime. There are some hardcoded 24's in the code right now. Quite sure that it is not that hard to transform those to variables, but not sure how it is done on the API side. Probably not something that will get high priority to cope with, but we'll discuss it and see if we can have a fix before March next year.