search

victronenergy / gui-v2

Other
28 stars 10 forks source link

PageSettingsHub4 should have a 'Dynamic ESS' item #1101

Closed DanielMcInnes closed 4 months ago

DanielMcInnes commented 5 months ago

See gui-v1 PageSettingsHub4.qml, PageSettingsDynamicEss.qml

blammit commented 5 months ago

Fixed by https://github.com/victronenergy/gui-v2/pull/1155

chriadam commented 4 months ago

As per testing on Tuesday: 1) If "Grid Metering" is not "External meter" then the Peak Shaving "Limit system AC import current" should have a popup saying why it cannot be enabled (i.e. because "Grid metering" is not set to "External meter"). 2) "Scheduled charging" should be "Scheduled charge levels" and it should have a summary text in the list item "Inactive" if none exist.

(Question: after one schedule is enabled but not active, should the test read "Scheduled" rather than "Inactive"?)

blammit commented 4 months ago

If "Grid Metering" is not "External meter" then the Peak Shaving "Limit system AC import current" should have a popup saying why it cannot be enabled (i.e. because "Grid metering" is not set to "External meter").

@ReinvdZee instead of showing this popup, I've added this information below the switch when the switch is disabled. I think this provides the information more effectively as you don't have to click it in order to see the popup message and understand why it's disabled. Is this okay?

image

ReinvdZee commented 4 months ago

@blammit,

@ReinvdZee instead of showing this popup, I've added this information below the switch when the switch is disabled. I think this provides the information more effectively as you don't have to click it in order to see the popup message and understand why it's disabled. Is this okay?

I agree, looking good!

blammit commented 4 months ago

Changes have been merged; closing.

DanielMcInnes commented 4 months ago

verified with Rein