search

victronenergy / gui-v2

Other
25 stars 9 forks source link

modbustcp list names cannot be fetched on wasm/MQTT #1146

Open blammit opened 4 months ago

blammit commented 4 months ago

Go to Settings > Services > Modbus TCP. Enable Modbus TCP if needed, and click 'Available services'. Observe the first line in each list item shows the full service name, e.g. "com.victronenergy.battery", instead of the device's product name or custom name.

This text is supposed to show the value of <service_uid/ProductName>, where is a value under mqtt/modbustcp/0/Services/, but this list of services contain strings like com.victronenergy.battery.tty0, which are valid on D-Bus, but not on MQTT.

Perhaps systemcalc could add a list under mqtt/modbustcp/0/ServiceInstances or such, to provide a list of instance numbers that corresponds to the entries in `mqtt/modbustcp/0/Services.

blammit commented 4 months ago

This was originally in https://github.com/victronenergy/gui-v2/issues/873, but moved this here as this is a lower-priority task compared to the other mentioned in that issue.