Closed chriadam closed 4 days ago
I don't know if you have seen the work I did with Tailscale integration. My TailscaleGX package is a wrapper around the tailscale mechanism providing a user interface and a connection state machine that reduces the steps needed by a user to setup tailscale. It is lacking the QR code interface for providing the URL to establish the connection but it otherwise functional
@kwindrem Tailscale will be integrated into Venus OS. You can check my fork of your repo and test it.
Here a link to the page which needs the QR code generation: https://github.com/victronenergy/gui-v2/blob/6f399c18d6f05329ff0192e008cb7c2cbc7338bd/pages/settings/PageSettingsTailscale.qml#L250
This is a nice to have for 1.0.0.
@mpvader would it maybe be better, if a cpp class or the Venus OS plattform can generate a QR code, which can then be used as a base64 image string via MQTT? I read somewhere what also in the MFD app QR code generation would be useful?
@mr-manuel maybe; but I don't think its necessary to add interdependencies like that; next we need to change the size of the QR code depending on where its shown, and an API is built, etc etc; while at the same time its should be trivial to make such thing with QT. And same to make a QR code with html5; trivial as well I expect. but if not - @chriadam ofcourse welcome to flag that
Adding 'blocked' label until we decide whether to add a victron git repo for qzxing, or apply a patch. This question will be resolved at the next meeting.
I add a short reminder here to enable the QR code part for the Tailscale page after this is solved.
@martinbosma can you make a repository for this? thanks.
@DanielMcInnes https://github.com/victronenergy/qzxing
Hi @martinbosma , I don't seem to have the permissions to push to that repo
dmcinnes@dmcinnes-System-Product-Name:~/git/victron/gui-v2/src/qzxing$ git push --set-upstream origin 1350-add-qr-code-generation-support-to-gui-v2
remote: Permission to victronenergy/qzxing.git denied to DanielMcInnes.
fatal: unable to access 'https://github.com/victronenergy/qzxing/': The requested URL returned error: 403
dmcinnes@dmcinnes-System-Product-Name:~/git/victron/gui-v2/src/qzxing$
@DanielMcInnes Should be fixed
@DanielMcInnes Should be fixed
Thanks Martin, looks good
For a third-party vendor (Tailscale) integration into VenusOS, QR code support is needed. The settings page which will be integrated into gui-v2 must be able to generate a QR code based on some system information.
So, possible solution: 1) import qzxing (Apache 2.0 license) as a git submodule and build it as a dependency within gui-v2 2) ensure that its types are registered into appropriate QML namespace for use within gui-v2 settings pages code 3) ensure that it is built statically for WebAssembly builds.
My understanding is that this is needed for v3.50 release i.e. 1.0.0 milestone.
Should discuss all of these details with Matthijs at the meeting on Thursday to double check that I understood the requirements correctly.