victronenergy / gui-v2

Other
28 stars 10 forks source link

GX (calibrated) temperature input precision #1368

Closed ReinvdZee closed 1 month ago

ReinvdZee commented 3 months ago

As of recently, the temperature inputs of the Cerbo GX Mk2 are being calibrated. However, the temperature is shown with 0 decimals precision. In the device page, there is actually 1 decimal, but its always 0:

image

If I heat the senser, it goes from 22.0 to 23.0 to 24.0, etc.

So we should decide on how many decimals we'd like to show for the GX temperature inputs and consistently implement that. Since we made an effort to calibrate it, we should at least have 1 decimal precision. This would also require a change dbus-adc, since it reports it without decimals.

@mpvader How many decimals should we have on the GX temp and GX tank 140 inputs? And should we distinguish between the calibrated and non-calibrated ones?

This will also be documented here

jhofstee commented 1 month ago

Just remove the decimal to fix this. At least I can't think of any case were it is of any additional value.

chriadam commented 1 month ago

Fixed.