search

victronenergy / gui-v2

Other
24 stars 9 forks source link

Inserting usb drive with firmware does not show firmware update page #1427

Open blammit opened 2 weeks ago

blammit commented 2 weeks ago

In gui-v1, inserting a usb drive with a firmware image will cause the firmware update page to appear. Also if you remove the usb drive without ejecting, an error notification is shown.

Neither of these occur with gui-v2.

DanielMcInnes commented 1 week ago

I think gui-v1 does this via StorageEventsDbus::vrmExternalStorageError(...), and this code in main.qml. 

    // Note: finding a firmware image on the storage device is error 4 for vrm storage
    // since it should not be used for logging. That fact is used here to determine if
    // there is a firmware image.
    Connections {
        target: storageEvents
        onVrmStorageError: {
            if (error === 4) {
                setTopPage(offlineFwUpdates)
            }
        }
    }

I think gui-v2 will need platform support to handle this. Marking as blocked for now.

mpvader commented 1 week ago

Jeroen will work on this, with priority.

mpvader commented 1 week ago

and, I've changed the prio from medium to low, since we will not block gui-v2 official release over this.