victronenergy / gui-v2

Other
30 stars 10 forks source link

Implement connectivity icons #1552

Open ReinvdZee opened 1 month ago

ReinvdZee commented 1 month ago

Implement the Wifi and cellular connectivity icons in the status bar, as per the design:

image

Not a blocker for V1.0.0.

DanielMcInnes commented 3 weeks ago

Hi @ReinvdZee , I can't find these icons in the design, do you know where they are?

blammit commented 3 weeks ago

@DanielMcInnes Icons are here: https://www.figma.com/design/GjCtz3A3jqSGvyjVvOm6RZ/GX-Touch-design?node-id=2110-140997&node-type=canvas&m=dev

But I think you added some components for the GSM settings a while back, to generate the icons for cellular strength? Don't remember if we added something similar for Wi-Fi settings as well.

nmbath commented 3 weeks ago

Would it be possible to also have an icon for ethernet being connected?

DanielMcInnes commented 3 weeks ago

@DanielMcInnes Icons are here: https://www.figma.com/design/GjCtz3A3jqSGvyjVvOm6RZ/GX-Touch-design?node-id=2110-140997&node-type=canvas&m=dev

But I think you added some components for the GSM settings a while back, to generate the icons for cellular strength? Don't remember if we added something similar for Wi-Fi settings as well.

thanks Bea

DanielMcInnes commented 3 weeks ago

Would it be possible to also have an icon for ethernet being connected?

We have a meeting later today, I'll bring it up then. @mpvader FYI

mpvader commented 1 week ago

hey @nmbath

Would it be possible to also have an icon for ethernet being connected?

no; too much clutter.

blammit commented 1 day ago

Setting medium priority for 1.1.0