Ukrainian translation of battery and settings menu header

[dirkjanfaber]

In Ukrainian the word "Battery" no longer gets translated into "Батарея". See https://github.com/victronenergy/gui-v2/blob/main/i18n/venus-gui-v2_uk.ts#L4425

Strangely enough this is not problem for other languages, which correctly translate the term.

And before v3.50~37 it was working correctly:

Feel free to test on https://vrm.victronenergy.com/installation/102195/dashboard

And also noticing that, when you switch translations, the menu header doesn't get updated until you re-enter the settings menu.

[podarok]

Tnx

[imval]

There is a similar issue for the French translation with the word "Automatic" that is not correctly translated in the UI in a few places, even though the key is present in Poeditor (the translation platform).

Dirk-Jan asked me to add this in this issue.

[podarok]

title seems like not only Ukrainian related @dirkjanfaber I have no rights to change it, on you

[chriadam]

The id for the "Battery" string is "common_words_battery", but this is missing from the locale-specific .ts files in the repository, although it IS present in the locale-specific .ts file in the build artifacts directory, from which the .qm files are generated... Interestingly, the translation is marked as "unfinished" there!

    <message id="common_words_battery">
        <location filename="../../gui-v2/components/CommonWords.qml" line="83"/>
        <source>Battery</source>
        <translation type="unfinished">Батарея</translation>
    </message>

/edit: I guess the first part is expected: we manually copy the .ts files to the build dir, then run lupdate on those copies, to avoid polluting the repo git diff with "mechanical" changes... But then, why is it marked as unfinished?

/edit2: I guess it's something to do with POEditor or Linguist. We don't invoke lrelease with the -nounfinished flag so they should still be included in the final translation catalogue .qm file. I wonder why they are not :-/

[chriadam]

I think we're running lrelease "too soon" i.e. on a version of the .ts which hasn't been properly updated by lupdate. We have some dependency logic in the CMakeLists.txt file to try to enforce proper ordering, but it seems like this might be failing.

[dirkjanfaber]

The cause for the unfinished marking seems to come from the fact that some translations are marked as "fuzzy" within poeditor. Even though that seems to be unrelated, I will ask the translators to check these fuzzy ones too and unmark the fuzzy checkbox if they have proofread it. The rabbit hole on fuzzy translations can be found here. 🐰

[dirkjanfaber]

Did test with the build from https://github.com/victronenergy/gui-v2/actions/runs/11626874251. Though "Battery" is correctly translated for Ukrainian, it isn't the case for "Automatic" in French.

While it is translated correctly on the ethernet configuration. 😕

Can it be that only one instance of the term actually gets translated?

[podarok]

Fixed in v3.51-beta2 for 'Battery' in Ukrainian Thank you

[chriadam]

Thanks, closing as fixed.