search

victronenergy / gui-v2

Other
24 stars 9 forks source link

Remove custom mock objects #590

Open blammit opened 8 months ago

blammit commented 8 months ago

With the addition of the mock VeQItemProducer, it should be possible to remove all the custom mock object types under data/mock, e.g. QtObject with properties for power, current etc. that do not link to a DataPoint/VeQuickItem. Instead, use actual DataPoint/VeQuickItem objects and modify the values for them directly.

This would help with testing as well, since we can use the same code path to modify both mock and non-mock data.

blammit commented 2 months ago

We should always set the /DeviceInstance to invalid when a device is removed in the mock system. See https://github.com/victronenergy/gui-v2/pull/1245

blammit commented 2 months ago

Something that Joona mentioned: with the mock data simulator, would be nice to have a key shortcut that would show device type (service type) for each list item on the devices list and for each widget on the overview pages