search

victronenergy / node-red-contrib-victron

MIT License
98 stars 19 forks source link

Reconnect the client if the connection was lost #11

Closed pkronstrom closed 5 years ago

pkronstrom commented 5 years ago

Currently, the dbus-listener.js does not reconnect, if the connection to the system dbus was lost for some reason. This will cause the victron energy nodes to hang in case the dbus service is restarted (or dbus service started after node-red, for example).

See https://github.com/sbender9/signalk-venus-plugin/issues/7 and https://github.com/sbender9/signalk-venus-plugin/blob/master/dbus-listener.js

mpvader commented 5 years ago

Note that; as in real life your code will run on the venus device; this will never happen.

There is no other oroject on Vneus OS that survives a dbus reset.

Instead; we have a watchdog that restarts the full venus device/os upon a dbus-daemon crash/reset

wollew commented 1 year ago

Note that; as in real life your code will run on the venus device; this will never happen.

I know this is an old issue, but I just ran into this issue. Your statement is only true if you're using this on the Venus device itself, if you deploy them to an external node-red instance then this can and will happen, a simple reboot of the Venus device is enough to trigger the problem.