search

victronenergy / node-red-contrib-victron

MIT License
87 stars 18 forks source link

The deleting of nodes is still not working 100% as expected and some nodes will not allow deletion #131

Closed dirkjanfaber closed 2 years ago

dirkjanfaber commented 2 years ago

Via https://github.com/victronenergy/venus/issues/378#issuecomment-1097748566 and https://github.com/victronenergy/venus/issues/378#issuecomment-1098055486

dirkjanfaber commented 2 years ago

Tried to reproduce this on v2.82-large-30, but failed so far:

2022-04-13 13:39:23.706447500 13 Apr 15:39:23 - [info] Uninstalling module: node-red-contrib-bigtimer
2022-04-13 13:40:59.944497500 13 Apr 15:40:59 - [info] Uninstalled module: node-red-contrib-bigtimer
2022-04-13 13:40:59.949012500 13 Apr 15:40:59 - [info] Removed node types:
2022-04-13 13:40:59.949726500 13 Apr 15:40:59 - [info]  - node-red-contrib-bigtimer:bigtimer
houser42 commented 2 years ago

My suspicion is that it may be remnants from older beta versions of Venus OS. Is that a possibility? A node installed under a version from many betas ago that gets stuck.. I think I have wiped the data partition in the past completely to get to a fresh start. is that still recommended? Many thanks!

xsilvergs548 commented 2 years ago

I also have difficulty un-installing nodes, please see attached images. Many thanks for all the great work. Screenshot 2022-04-13 14 27 27 Screenshot 2022-04-13 14 28 00 Screenshot 2022-04-13 14 28 27

houser42 commented 2 years ago

Here is my complete list of news that can not be uninstalled if that helps.

node-red-contrib-bigtimer 2.8.1

node-red-contrib-dsm 0.14.1

node-red-contrib-influxdb 0.6.1

node-red-contrib-looptimer 0.0.8

node-red-contrib-solar-power-forecast-plus 2.0.6

node-red-contrib-timerswitch 1.4.0

node-red-contrib-ui-digital-display 1.0.3

node-red-contrib-xterm 1.0.1

dirkjanfaber commented 2 years ago

This could very well be a remnant from an older version. We try to be backward compatible and not to break things when updating, but sometimes things get overlooked and this might be such a thing. If I install a node via the palette and remove it with rm on the Cerbo, Node-Red still thinks they exist (and they do in package.json). Not too sure if there is a command to have npm re-investigate the existing packages, but editing the file by hand is a possibility.

dirkjanfaber commented 2 years ago

I'll close this issue as it seems to be a remnant from older upgrades. Not much to do about it apart from removing the nodes from package.json.