victronenergy / node-red-contrib-victron

MIT License
90 stars 18 forks source link

Improve no devices found text #37

Closed mpvader closed 5 years ago

mpvader commented 5 years ago

Below screenshot shows what you see after dragging in a node for which there is no matching device on the system. Lots of people will see it; for many it will even be the first thing they see; at least it was like that for me :).

Change the text to No matching devices found. Pick a different node from the palette., or something better.

image

pkronstrom commented 5 years ago

It might be better to show disabled dropdowns and a message below them instead of a big scary yellow box. Also, specifying the device type in the message is less ambiguous.

Here's a suggestion:

On a new node, the dropdowns are disabled and a red warning text. Screenshot 2019-03-12 at 10 29 25

When a previously selected device appears disconnected, the selected values are shown, but not editable. A different warning text is shown.

Screenshot 2019-03-12 at 10 29 50

Proposed changes here

pkronstrom commented 5 years ago

New style

Screenshot 2019-03-12 at 15 15 31

pkronstrom commented 5 years ago

Merged to master