search

victronenergy / venus-html5-app

HTML5 App including Javascript library that communicates with Venus OS over MQTT websockets
MIT License
98 stars 32 forks source link

bug: npm update of `jest` and `jest-circus` breaks the tests as well as `venus-docker` repo #386

Open mman opened 2 weeks ago

mman commented 2 weeks ago

So automated update of jest and jest-circus is not as innocent as it looks... (https://github.com/victronenergy/venus-html5-app/commit/0fa987a93e60ad5e29186860331cdff914e9450d)

It actually breaks the automated tests completely... see for example the run here:

https://github.com/victronenergy/venus-html5-app/actions/runs/9583350718

And it also breaks venus-docker master which no longer builds due to peer dependency issue:

> [html5-app 4/6] RUN npm install:                                                                                                                                                  
...
1.333 npm error code ERESOLVE                                                                                                                                                        
1.334 npm error ERESOLVE could not resolve                                                                                                                                           
1.334 npm error                                                                                                                                                                      
1.334 npm error While resolving: jest-watch-typeahead@0.6.5                                                                                                                          
1.334 npm error Found: jest@29.7.0                                                                                                                                                   
1.334 npm error node_modules/jest                                                                                                                                                    
1.334 npm error   jest@"^29.7.0" from the root project                                                                                                                               
1.334 npm error                                                                                                                                                                      
1.334 npm error Could not resolve dependency:                                                                                                                                        
1.334 npm error peer jest@"^26.0.0 || ^27.0.0" from jest-watch-typeahead@0.6.5                                                                                                       
1.334 npm error node_modules/jest-watch-typeahead
1.334 npm error   jest-watch-typeahead@"^0.6.1" from the root project
1.334 npm error
1.334 npm error Conflicting peer dependency: jest@27.5.1
1.334 npm error node_modules/jest
1.334 npm error   peer jest@"^26.0.0 || ^27.0.0" from jest-watch-typeahead@0.6.5
1.334 npm error   node_modules/jest-watch-typeahead
1.334 npm error     jest-watch-typeahead@"^0.6.1" from the root project

Need to look into this.