victronenergy / venus

Victron Energy Unix/Linux OS
https://github.com/victronenergy/venus/wiki
580 stars 73 forks source link

can-bus-bms: Remove hardcoded DeviceInstance 512, allocate dynamically #1168

Open izak opened 11 months ago

izak commented 11 months ago

At the moment, this hardcoded DeviceInstance means only one CAN-bms battery can be accommodated, even if you have two capable CAN-bus ports.

Dynamically allocating it will allow a second battery to go on 513.

p0l0us commented 1 month ago

Many people including me are suffering by this issue. Is there any chance to fix this ? I'm happy contribute if anyone point me to right place.

We see two BMS connected via different CAN busses in the GUI, but there are issues - VRM is confused, system battery & DVCC controller is assigned randomly after CerboGX restart, also in node-red are values alternating within single battery. On other hand SignalK sees batteries separate with same Path (electrical.batteries.512), but different Source.

p0l0us commented 1 month ago

another related ticket: https://github.com/victronenergy/venus/issues/1059