Add network control to Venus-platform

ReinvdZee commented 5 months ago

[x] high prio items for v3.40 done
[ ] cleanup / further improvements - see below.

Initial description

Gui-v2 requires the network settings to be exposed to dbus. see victronenergy/gui-v2#618.

Gui-v1 interacts with connman directly, gui-v2 will not, so the settings need to be exposed to dbus. Venus-platform will take care of this.

ReinvdZee commented 3 months ago

Network control was added to venus-platform and gui, see https://github.com/victronenergy/gui-v2/issues/618.

jhofstee commented 1 month ago

gui-v1 changes:

When a networks is not connected to yet, the IP configuration is now shown as Unknown, instead of automatic.
The unknown ip info used displayed as --, but changed to empty strings
TypeError: Result of expression 'services["wifi"][networkName]' [undefined] is not an object get reported quite often.
The order is a of the wifi networks seems to be [Name, connected] so the connected ones end up at the bottom instead of the top.
the selected index isn't maintained (because of the array as model instead of a abstract model derived one)

venus-platform:

it an report agent already registered. Don't know how to reproduce that at the moment
state info seems outdated at times, e.g. disconnected while being connected etc. No idea how to reproduce that either.
(or gui-v1) branch, when switching from automatic to manual, I ended up with a 3 digit dns server. Can't reproduce either.

dbus-tool

dbus-y doesn't like spaces in wifi names. Not important but looks confusing.

I will include the venus-platform v1.40, so at least gui-v2 can start using it and the we can check if mentioned is can be reproduced there as well or not.

I pushed my gui-v1 branch here https://github.com/victronenergy/gui/commits/jeroen/network_control/. It now serializes the json code before sending. The bluetooth availability is now reported by venus-platform.

mpvader commented 3 weeks ago

@jhofstee am I correct in seeing that:

all changes are included venus-platform
for gui-v1 we didn't include the changes for this
so far all works well, so can be released as is in v3.40 ?

jhofstee commented 2 weeks ago

yes, there is room for improvement, like sorting the networks etc. But that is better then not being able to configure the network at all ;)

victronenergy / venus

Add network control to Venus-platform #1215

Initial description