search

victronenergy / venus

Victron Energy Unix/Linux OS
https://github.com/victronenergy/venus/wiki
543 stars 69 forks source link

alternator/Orion XS: NetworkMode is not correctly set with VE.Bus BMS v2 #1262

Closed izak closed 1 month ago

izak commented 2 months ago

Original text below: The issue is deeper than this. I initially thought it was simple, but it turns out I DID think about this when I made the implementation. So the user is complaining about something else, and more work is needed to find out what is really wrong.

The complaint is that the BMS controlled flag is not set in a system with an Orion XS and a VE.Bus BMS v2.

Original text. This was introduced in Venus 3.30.

Venus 3.20 had a bug, where alternator power would be fed into the grid, because the Orion XS was treated the same as a solar charger. When fixing this, inadvertently the NetworkMode was no longer set on the Orion XS, which means it is unaware of a BMS in the system.

It will still follow the charge voltage from the battery, and will still shut down when instructed, but if it loses comms with the BMS, it will go into standalone mode instead of raising error 67.

Fix: Set the correct NetworkMode on alternator devices.

izak commented 1 month ago

This was already fixed in Venus 3.30. The reporting customer was running 3.20. Nothing to be done here, but a unit test was added to make sure it remains fixed.