search

victronenergy / venus

Victron Energy Unix/Linux OS
https://github.com/victronenergy/venus/wiki
543 stars 69 forks source link

Adaptive brightness makes the backlight pulse #1265

Closed jpetrell closed 2 months ago

jpetrell commented 2 months ago

Customer (Lars F., Matthijs' contact) is reporting that adaptive brightness on his Cerbo GX v3.40~10 is pulsating:

https://github.com/victronenergy/gui-v2/assets/5200296/3b185514-d072-4bdf-a23d-ca62e266a3d9

Originally filed for gui-v2, which reported two issues: broken settings switches (fixed in gui-v2) and pulsating display brightness (issue here). Reported pulsation here as gui-v2 doesn't implement the adaptive brightness, just provides the user setting.

mpvader commented 2 months ago

What does @ReinvdZee need to do @jpetrell ?

Run latest gui-v2 and see if he can reproduce it? And if not, then lets close the issue. I'll report back to Lars that he can try with a later Venus OS version.

jpetrell commented 2 months ago

What does @ReinvdZee need to do @jpetrell ? Run latest gui-v2 and see if he can reproduce it?

Yeah try to repro. Though I couldn't reproduce, and neither likely can @ReinvdZee. Also, could review the adaptive brightness code for flaws, or try to reduce likelihood of the issue by making the brightness steps smaller, add some time filtering, implement hysteresis to avoid constant jumps, etc.

And if not, then lets close the issue

Yeah, I guess only do more investigations if more people start reporting the issue.

ReinvdZee commented 2 months ago

I also cannot reproduce this issue on Venus 3.40~13 (gui-v2 v0.2.18) on both Ekrano and Cerbo.

mpvader commented 2 months ago

ok closed then.