generator: rename /AutoStart path

victronenergy / venus

Victron Energy Unix/Linux OS

https://github.com/victronenergy/venus/wiki

577 stars 72 forks source link

generator: rename /AutoStart path #1267

Closed philipptrenz closed 1 month ago

philipptrenz commented 4 months ago

Rename com.victronenergy.genset and com.victronenergy.dcgenset path /AutoStart to /RemoteStartModeEnabled and also change wording in gui's. The reason is to have less ambiguity compared to our own autostart/stop feature.

Here are the new definitions:

"Remote Start Mode" → 3rd party generator mode required for remote start through GX device, usually via Modbus
"Auto Start/Stop" → our own start/stop software feature

Todo list / status:

[x] Change the dbus path name, modal, documentation, see google sheet https://docs.google.com/spreadsheets/d/1kEftK23GIX-GQCRgFjbXJmAdEidw6hfn1g6QZ8AINwA/edit#gid=0
[x] See if we need to change the wording of On/Off/Autostart-stop in PageAcInModelGenset.qml; probably needs meeting with Philipp, Rein and Matthijs - possible Martin to make sure it aligns with FP as well.

@martinbosma asked for syncing this with https://github.com/victronenergy/venus-private/issues/316

philipptrenz commented 4 months ago

@jepefe: Does the dbus_generator "Autostart mode not enabled" alert, see below screenshot, watch for the remote generator or the service to be set to "Auto start/stop"?

Ie this feature:

ReinvdZee commented 4 months ago

So we don't forget; we should update these as well:

https://github.com/victronenergy/venus/wiki/dbus#generator-data https://www.victronenergy.com/live/ccgx:fischer_panda#troubleshooting

mpvader commented 4 months ago

good one. I've added it to the tracker in the google sheet

mpvader commented 4 months ago

@jepefe: Does the dbus_generator "Autostart mode not enabled" alert, see below screenshot, watch for the remote generator or the service to be set to "Auto start/stop"?

the answer to that is no. I'll make a new issue now to get that added: https://github.com/victronenergy/venus/issues/1274

ReinvdZee commented 4 months ago

@philipptrenz, @mpvader,

The genset controller menu has the setting "Mode" (qml), which can currently be set to "on", "off" or "Auto start/stop":

We're not sure if the "Auto start/stop" option of the "mode" menu should be renamed as well.

When set to "Auto start/stop", control is handed over to the generator start/stop by:

com.victronenergy.generator.startstop1/ManualStart = 0 --> Manually turning off the generator relay first and
com.victronenergy.generator.startstop1/AutoStartEnabled = 1 --> Enabling generator auto start/stop

So the genset will be controller by the auto start/stop feature of dbus_generator.

I suppose this is the "Auto start/stop" feature @philipptrenz was talking about here:

"Auto Start/Stop" → our own start/stop software feature

If so, then this Mode item does not need renaming.

philipptrenz commented 4 months ago

@ReinvdZee Yes, the above is our own "Auto Start/Stop" feature, so please keep the gui string as is.

ReinvdZee commented 4 months ago

Thanks @philipptrenz for your answer. We will leave that gui string as is.

ReinvdZee commented 4 months ago

Because there was quite some confusion about the generator start stop feature, we described the implementation of the auto start/stop feature in a document.

In addition to renaming the /AutoStart path, there are two other changes:

Make the "Auto start/stop" submenu in PageAcInModelGenset.qml always visible.
Change the toast text issued when mode is set to "on" but the genset cannot be remotely started to: "Unable to start the genset because its remote start functionality is disabled. Enable it on the genset control panel"