DSE: add path to remotely enable autostart mode on the DSE controller

victronenergy / venus

Victron Energy Unix/Linux OS

https://github.com/victronenergy/venus/wiki

577 stars 72 forks source link

DSE: add path to remotely enable autostart mode on the DSE controller #1273

Closed mpvader closed 3 weeks ago

mpvader commented 4 months ago

Work has been done by Philipp:

https://github.com/victronenergy/dbus-modbus-client/tree/philipptrenz/dse-autostart-mode-switch

But needs some changes, and please link to this issue in the commit.

this should have a different name, now that we've renamed /Autostart. How about /RemoteStartEnable ?
And the other thing what is missing is either comments in the code or here is something that that explains the background of that option in more detail. Ie. is there a user setting on the DSE that enables SCF_SELECT_AUTO_MODE? Or does it depends on the model.

mpvader commented 4 months ago

this is to be assigned to @philipptrenz, but for some reason I can't

philipptrenz commented 4 months ago

Also can't assign it to myself.

DSE has binary flags indicating if certain functionality is available, which indeed depends on the model. The path gets only added, if the controller indicates that this functionality is available.

philipptrenz commented 4 months ago

Decided to go with /SetRemoteStartMode to differentiate between new /RemoteStartModeEnabled, I will now update the dbus wiki entry.

mpvader commented 4 months ago

can you both disable and enable the remote start mode via that path @philipptrenz ? And do we even want to allow disabling that from a GX device?

If not, how about slightly different: /EnableRemoteStartMode.

only disadvantage is that on dbus-spy they'll be far apart due to alphabetic ordering

philipptrenz commented 4 months ago

Typically, there are more than two modes and they differ in meaning/naming between manufacturer. So it makes sense to only allow engaging of remote start mode and resetting has to be done on the genset itself, I'd say.

I agree on /EnableRemoteStartMode , will adjust accordingly.

@mansr That's also relevant for the mans/cre branch on dbus-modbus-client.

philipptrenz commented 3 weeks ago

/EnableRemoteStartMode was added to the DSE integration as ofh dbus-modbus-client v1.53, closing