victronenergy / venus

Victron Energy Unix/Linux OS
https://github.com/victronenergy/venus/wiki
543 stars 69 forks source link

Dbus-flashmq: rate-limit keep-alives #1276

Closed wiebeytec closed 3 weeks ago

wiebeytec commented 1 month ago

It's been observed that a significant amount of installations get hundreds of unsuppressed keep-alives within a second, either over LAN or WAN. This causes many republishes of all topics, up to hundreds of thousands.

We can easily limit the amount of keep-alives that are used for re-publishing to something like 2 per second. That is still extremely high for a normal usecase so should not interfere, but will prevent overloads on mistakes.