Connected gensets step 2: complete the UI/UX cleanup

[mpvader]

In v3.33 we are making, a few changes to improve the UI. Some things were left out to not delay releasing v3.33 any further.

This issue is to list the things we need to look into as a follow-up:

• [x] #1315
• [x] There is no runtime reset button for the DSE controller (or is there @philipptrenz ? )
• [x] There are two error states, one in the top level menu, and one in the lower one (fixed in v3.40 and backported to v3.33).
• [x] The status of the Remote start option (in the genset panel) is now not visible in the GX menus; its only visible when its wrong. Consider fixing that (fixed in v3.40 and backported to v3.33).
• [x] #1316
• [ ] Make sure all UIs are aligned (gui-v1, gui-v2, VRM, html5-app)

[philipptrenz]

There is no runtime reset button for the DSE controller (or is there?)

No, I think the generator runtime is like the odometer on a car, it should not be manipulable.

One note to service interval: Some controllers have their own service interval counter with reset option, but I think it's fine that both systems provide that and it is up to the customer to decide which one to use.

[mpvader]

@philipptrenz , sorry, I wasn’t clear: I meant button to reset the service interval counter. Totally agree on the total runtime counter.

Does our system already use the DSE runtime counter for its own counting? Or if not the DSE status (running/stopped) in order to when when the counter needs to count and when not?

[philipptrenz]

@mpvader As far as I know, it does not use the reported runtime of the genset, but I think it initially uses the readings when a genset is first found, which still causes the values to drift apart.

[philipptrenz]

I want to propose to streamline this issue with additional tasks:

• [ ] Allow to enable Remote start mode via gui → see https://github.com/victronenergy/venus/issues/1273
• [ ] Replace "Generator stop time" for connected gensets, as we know when they are actually stopped
• [ ] Replace "Generator stop time" when state is reported by digital input (see here)

[philipptrenz]

I also have a stack of VRM issues related to generator, which El Niño asked to discuss next Wednesday with me and @ReinvdZee:

• https://github.com/victronenergy/vrm-portal/issues/318
• https://github.com/victronenergy/vrm-portal/issues/317
• https://github.com/victronenergy/vrm-portal/issues/316
• https://github.com/victronenergy/vrm-portal/issues/315
• https://github.com/victronenergy/vrm-portal/issues/314

[mpvader]

One more here. And for me its not necessary to fix that in gui-v1; lets just make sure its 100% in gui-v2.

[mpvader]

Hey @philipptrenz ,

I also have a stack of VRM issues related to generator, which El Niño asked to discuss next Wednesday with me and @ReinvdZee:

I went through those issues; finally - sorry for the delay. See my responses there - hope that helps!

[ReinvdZee]

I've added a todo item for the clear error gui button currently implemented. The current implementation was originally added for FP but is outdated. It does not do anything on the genset (possibly only on very old genset firmware versions, according to @martinbosma). Newer gensets support clearing errors via Modbus.

We should offer the option to clear errors remotely only when that is actually supported by the genset.

[ReinvdZee]

I moved some of the tasks to separate issues to track them separately.

[philipptrenz]

Just noticed, that the error message says "Remote switch control disabled", but should now say "Remote start mode disabled". I suspect that this may have slipped through during path renaming.

[ReinvdZee]

Most of the bullet points are checked. As per the UI alignment, gui-v1 and v2 won't be in sync since we're not doing all changes to v1 anymore. And the other UI-related items are tracked in different issues. (see this one about VRM).

Closing this issue.