search

victronenergy / victron-press

Based on vuepress - this a set of tools to maintain and publish documentation using md as a source format
1 stars 1 forks source link

Front end fails to update - "Last updated: " #12

Open Wholistic opened 5 years ago

Wholistic commented 5 years ago

The 'Last updated' which is located on the bottom right of the front end manual display, and the top of the front end editing display does not update when the document is changed.

While in that section, it would also be nice to see WHO did the update, and even a link to the GitHub commit of that update.

Screen Shot 2019-05-29 at 12 39 31 pm

Screen Shot 2019-05-29 at 12 37 35 pm

DvdGiessen commented 5 years ago

The root of this issue is a bug in Vuepress. I've opened a pull request with them to resolve the issue, but we might be out of luck to implement this until we update to the 1.x release.

lasselicht commented 5 years ago

@DvdGiessen now that 1.x is out do you know if your pull request has been accepted yet?

DvdGiessen commented 5 years ago

It has not. In fact, the entire 1.0.0 release came a bit unexpected. I'm hoping we'll see the fix merged in before we make our next 0.5.x release.

mpvader commented 5 years ago

I don’t understand.

Can’t we run our own fixes on vuepress?

DvdGiessen commented 5 years ago

In the current version of VuePress we're using (0.x) it is integrated deep in its internals, making it hard to fix it without forking their entire codebase.

However, in the recently released 1.x version this should be easy to fix, since they have split out the functionality in separate modules meaning we can patch the specific module without forking VuePress entirely.

Since we're already planning to move to the more stable 1.x version (if all goes well in the next release), I'll be including the fix with that.