search

victronenergy / victron-press

Based on vuepress - this a set of tools to maintain and publish documentation using md as a source format
1 stars 1 forks source link

Image broken in front end editor, but works on the site #13

Open Wholistic opened 5 years ago

Wholistic commented 5 years ago

Screen Shot 2019-06-08 at 5 50 00 pm

Screen Shot 2019-06-08 at 5 50 12 pm

https://docs.victronenergy.com/gx/maxi-gx.html#troubleshooting

DvdGiessen commented 5 years ago

Issue seems to be that the image is too big and the GitHub API refuses to serve it. We'll have to work around that.

Wholistic commented 5 years ago

Do you know what the size limit is?

Another example here, for a gif that is ~2MB.

https://docs.victronenergy.com/victronconnect-vebus.html?editmode=true Screen Shot 2019-06-12 at 1 19 51 am

lasselicht commented 5 years ago

@DvdGiessen any clue on the max size?

mpvader commented 5 years ago

Note that this is non urgent. What is urgent, is fixing the cache, making it possible to edit chapter rather than the whole thing; and there after the priority will shift to making good PDFs, including possibly also multiple language PDFs.

DvdGiessen commented 5 years ago

Maximum size per the GitHub API documentation is 1MB. We'll include fixing this as a low priority, first working on those other issues.