fix missing semicolons - Githubissues

vicvega / chaltron

Template generator for rails application with bootstrap, devise...

MIT License

9 stars 2 forks source link

fix missing semicolons #19

Closed jonnynux closed 5 years ago

crondaemon commented 5 years ago

You opened a new PR before the other was merged. As a result, we need to review 2 instead of one. Don't do it. Wait before the first gets merged, then open a new one with the final (accepted) commit.

crondaemon commented 5 years ago

The CI fails on ruby 2.2, but it doesn't seem related to the patch. @vicvega can you look?

vicvega commented 5 years ago

@jonnynux please rebase on current bootstrap3 branch.

it should be fixed

coveralls commented 5 years ago

Coverage decreased (-0.1%) to 96.014% when pulling f5c6a01874c3573ad20b1bec967eb7ef9a5bb700 on jonnynux:semicolons3 into f9f5c98c669362e43fd6cf854c978e24f10d9ead on vicvega:bootstrap3.