search

vicwomg / pikaraoke

Youtube-based Karaoke machine for Raspberry Pi, OSX, Windows, and Linux
GNU General Public License v3.0
461 stars 117 forks source link

workaround for 'required interaction' with browser #285

Closed RecursiveFunctions closed 6 months ago

RecursiveFunctions commented 6 months ago

this allows PiKaraoke to autoplay without needing to click 'Confirm'. This only applies to the browser on the host machine. visiting /splash from your phone would still require tapping 'Confirm'.

This works with raspberry pi4 (8GB ram) with bookworm

vicwomg commented 6 months ago

Are you sure this is necessary? Selenium auto-dismisses the Confirm button, so this should be already handled. The only time you need to click it is you launched manually in another browser.

RecursiveFunctions commented 6 months ago

Ah, didn't know that. But this line also fixes an unrelated issue where, in a wayland environment the browser window is displayed improperly, so there is that.

I happened to be in wayland, just tested it both with and without the change to be sure.

https://github.com/vicwomg/pikaraoke/assets/3803876/64ba7391-12d0-429c-b12f-e45b86db9e5e

vicwomg commented 6 months ago

Oh good to know I’ll merge this then! I saw that Wayland issue and I just switched out of Wayland in raspi config and forgot about it.

On Thu, Dec 21, 2023 at 12:19 PM Ray @.***> wrote:

Ah, didn't know that. But this line also fixes an unrelated issue where, in a wayland environment the browser window is displayed improperly, so there is that.

I happened to be in wayland, just tested it both with and without the change to be sure.

— Reply to this email directly, view it on GitHub https://github.com/vicwomg/pikaraoke/pull/285#issuecomment-1866881977, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7KXNWDPW2LYUJEMCA7GDLYKSKURAVCNFSM6AAAAABA6DI7A6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRWHA4DCOJXG4 . You are receiving this because you commented.Message ID: @.***>

vicwomg commented 6 months ago

I have manually added this to my working branch, so no need to merge this. Thank you!

frankchau93 commented 4 months ago

this allows PiKaraoke to autoplay without needing to click 'Confirm'. This only applies to the browser on the host machine. visiting /splash from your phone would still require tapping 'Confirm'.

This works with raspberry pi4 (8GB ram) with bookworm

I know the issue is closed but I have to ask, how does --start-maximized bypass the need to click the button?

vicwomg commented 4 months ago

this allows PiKaraoke to autoplay without needing to click 'Confirm'. This only applies to the browser on the host machine. visiting /splash from your phone would still require tapping 'Confirm'. This works with raspberry pi4 (8GB ram) with bookworm

I know the issue is closed but I have to ask, how does --start-maximized bypass the need to click the button?

It doesn't. This fixes another issue " this line also fixes an unrelated issue where, in a wayland environment the browser window is displayed improperly, so there is that"

As for how I bypass it otherwise, Pikaraoke auto-dismisses the confirm button with a simulated button click in selenium. But only if you're running in headed mode. Otherwise, you must manually click it.

frankchau93 commented 4 months ago

this allows PiKaraoke to autoplay without needing to click 'Confirm'. This only applies to the browser on the host machine. visiting /splash from your phone would still require tapping 'Confirm'. This works with raspberry pi4 (8GB ram) with bookworm

I know the issue is closed but I have to ask, how does --start-maximized bypass the need to click the button?

It doesn't. This fixes another issue " this line also fixes an unrelated issue where, in a wayland environment the browser window is displayed improperly, so there is that"

As for how I bypass it otherwise, Pikaraoke auto-dismisses the confirm button with a simulated button click in selenium. But only if you're running in headed mode. Otherwise, you must manually click it.

I understand, thanks for replying. The reason why I ask is because sometimes the browser is non-responsive on my raspberry pi 4. There would be a point where nothing would show or queue up on the browser and I'd just have to restart my pi to make it work. It's something I'm not too sure how to debug so i was thinking of adding a refresh button somewhere but it would require me to click on the button again which i can't do 😅

vicwomg commented 4 months ago

I understand, thanks for replying. The reason why I ask is because sometimes the browser is non-responsive on my raspberry pi 4. There would be a point where nothing would show or queue up on the browser and I'd just have to restart my pi to make it work. It's something I'm not too sure how to debug so i was thinking of adding a refresh button somewhere but it would require me to click on the button again which i can't do 😅

Sounds like a bug, does it occur frequently? if you can manage to narrow down a way to reproduce it, then you should file a ticket.