search

vicwomg / pikaraoke

Youtube-based Karaoke machine for Raspberry Pi, OSX, Windows, and Linux
GNU General Public License v3.0
461 stars 117 forks source link

FEATURE REQUEST: Search multiple paths for songs #286

Open RecursiveFunctions opened 6 months ago

RecursiveFunctions commented 6 months ago

Given the limited storage space of micro SD cards for Raspberry Pis, it'd be great if Pikaraoke could also search external drives or even other hosts on the same network.

Ideally, if I plug in an external sdd to my pi, pikaraoke should be able to detect that automatically. if my friend also happens to bring his usb stick full of his own songs and plugs it in, pikaraoke should be able to list songs from both sources.

I considered using aufs to combine multiple mount points into one such that pikaraoke would be able to access songs from each of them as if it was one directory.

another possible alternative would be to have Pikaraoke take in multiple paths and search them. maybe make a list?

I think the former implementation would not be compatible with windows, but the latter should be cross-platform.

Edit: looks like using mount --bind would also work (for linux) https://www.phind.com/search?cache=mxx94g0k82mc3rtetkm5hedw

vicwomg commented 6 months ago

On the point of limited SD storage space, why not just change the default download directory to your mounted drive with the -d option?

To implement multiple search paths in a cross-platform way, probably want to add a separate CLI parameter that can take a comma-separated list of additional paths and add them to the initial startup scan.

RecursiveFunctions commented 6 months ago

On the point of limited SD storage space, why not just change the default download directory to your mounted drive with the -d option?

I would, but I run into the path handling problem #287 since my drive has a space in the name.

To implement multiple search paths in a cross-platform way, probably want to add a separate CLI parameter that can take a comma-separated list of additional paths and add them to the initial startup scan.

-p --paths maybe? I'll use that as a placeholder unless/until there's a better name

Having it separate from -d is also good because maybe the user wants downloaded songs to at specific location separate from their collection.

vicwomg commented 6 months ago

Gotcha, I’ll see if I can get that path issue fixed tonight. Seems doable.

On Sat, Dec 23, 2023 at 4:17 PM Ray @.***> wrote:

On the point of limited SD storage space, why not just change the default download directory to your mounted drive with the -d option?

I would, but I run into the path handling problem #287 https://github.com/vicwomg/pikaraoke/issues/287 since my drive has a space in the name.

To implement multiple search paths in a cross-platform way, probably want to add a separate CLI parameter that can take a comma-separated list of additional paths and add them to the initial startup scan.

-p --paths maybe? I'll use that as a placeholder unless/until there's a better name

Having it separate from -d is also good because maybe the user wants downloaded songs to at specific location separate from their collection.

— Reply to this email directly, view it on GitHub https://github.com/vicwomg/pikaraoke/issues/286#issuecomment-1868396602, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7KXNTHVGOEWZOJ2FTVXIDYK5YBVAVCNFSM6AAAAABA6EWYXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGM4TMNRQGI . You are receiving this because you commented.Message ID: @.***>