vicwomg / pikaraoke

Youtube-based Karaoke machine for Raspberry Pi, OSX, Windows, and Linux
GNU General Public License v3.0
461 stars 117 forks source link

[BUG] -d and -y options don't work with paths that have spaces in them #287

Closed RecursiveFunctions closed 6 months ago

RecursiveFunctions commented 6 months ago

this screencap shows the issue with only -d , but it's the same as with -y issue_screencap

I tried with quotes and escaping the space but the path handling for both options does not work with paths that have spaces in the name.

vicwomg commented 6 months ago

Note to self/whoever wants to take this on: Looks like there's some additional handling for python argparse required to parse spaces:

https://stackoverflow.com/a/26990349/2909171

vicwomg commented 6 months ago

This should be fixed in the latest pull of this branch 277-html_ffmpeg_video_rendering

lmk if it works out

vicwomg commented 6 months ago

merged this to main as 1.2