search

vicwomg / pikaraoke

Youtube-based Karaoke machine for Raspberry Pi, OSX, Windows, and Linux
494 stars 129 forks source link

[FEATURE] Pikaraoke should run on a single port (proxy http requests to ffmpeg streams) #303

Open vicwomg opened 9 months ago

vicwomg commented 9 months ago

Description People who are hosting pikaraoke are running into issues due to ffmpeg streaming on a different port. This makes it difficult to host pikaraoke outside of the LAN because multiple ports would need to be forwarded. Also, it seems as though Safari is struggling to stream from port 556 #299

Describe the solution you'd like Have pikaraoke flask server proxy the ffmpeg stream URL, in specific location like /stream

Describe alternatives you've considered Other solutions involved overriding the ffmpeg url + router proxying or using nginx proxies to achieve the same thing. Too complex for most users.

Additional context

293 #301

honestlai commented 9 months ago

Already pulled this into my docker setup... works like a charm 🍻

vicwomg commented 9 months ago

This is on hold because it appears to cause issues with transcoded files when streaming remotely. mp3 + cdg, non-mp4 video formats, and transposed audio will be transcoded.

frankchau93 commented 9 months ago

Already pulled this into my docker setup... works like a charm 🍻

What's your docker setup look like?