Closed meinaart closed 2 years ago
so this is about the general fanart, not season fanart or extra fanart? and for the movies or tv section?, does it happen on a specific item or on all items? It should indeed skip downloading an image if it's already locally available.
It happens for every tv show. But because it does not continue (it keeps hanging on not finding a backdrop) only the first show is affected.
I think this bug has been effective for a longer period because I noticed that all my fanart.jpg's where nullified. So if I choose "missing images for all" then only the first show gets affected. If I choose "for selection" then only selection is affected.
General fanart/backdrop, not season fanart or extra fanart. If I choose to download a backdrop via the extras menu it works fine. But if I choose download missing images then it keeps hanging on "Download Backdrop Image".
Does it hang with a spinning beach ball? or does it take more then a minute before you press the cancel button?
No spinning beach ball. It continues if I let it go. But it still nullifies my fanart.jpg.
Probably unlikely the reason, but is the drive that the fanart.jpg file is on case sensitive?
Well it might be unlikely but the drive is indeed case sensitive.
Then it might be because, while all the other art is written as lowercase, and in all other art is 'detected' in lowercase, I may have accidentally detected the fanart file in Titlecase. (So it would search for 'Fanart.jpg' instead of 'fanart.jpg' while in every othercase i do search for lowercase files.) So that would be why ViMM didn't recognise the file as already available, and it means that i'll have to do some retooling for case sensitive drives.
I'm still not exactly sure why it would zero out the original file though.
Me neither. It's hard to replicate. It might also be a problem on a higher level (AFP or Samba or something).
If you remove the fanart.jpg altogether, does it still hang?
Maybe hanging is not the right word. Interface is still responsive, it just takes a long time. After a while the "Downloading... backdrop image" dialog just disappears.
Behavior after removing the fanart.jpg is the same. A zero byte fanart.jpg is created. Which is quite remarkable because if I create an empty file via terminal with echo "" > test.txt a 4k file is created.
Since it only happens on multi-art downloads, I know where the problems is, i'm using a slightly different method to download images there. Since it's an inconvenient method anyhow, i'll probably change it back to the more convenient one, it probably didn't do what I wanted it to do anyhow.
In the latest nightly (can't check the version because app crashes when I try to open the about dialog) my fanart.jpg get's overwritten by a zero byte file if i choose "Download missing images for all".
I think this happens because it can't find the backgrounds when I choose "Download missing images for all". It's also a bit strange that it tries to download a new fanart image while there is a fanart image present (this is also indicated by the GUI (icon in list) and correctly showed in the app itself).