videah / SkyBridge

A work in progress bridge/proxy that lets you use Mastodon apps with Bluesky
https://skybridge.fly.dev
MIT License
543 stars 36 forks source link

Images not shown in quote posts #33

Closed felixmueller closed 10 months ago

felixmueller commented 1 year ago

I just experienced a problem with quote posts containing images:

Ivory via SkyBridge: image

Bluesky: image

Thank you very much for looking into this! 🙏

videah commented 1 year ago

Unfortunately this is a side effect of how we're abusing embed cards to handle quote posts, Ivory will either display a card or display an image, but not both 😔 I'm not sure how to go about fixing this other than maybe not showing a card when there's an image and just showing a link instead

mergesort commented 1 year ago

I think not showing the card and showing the link instead is a great solution, preferred even since it's Ivory's default behavior.

felixmueller commented 1 year ago

I would go for a link instead of the card for cases where posts contain images as well. Of course it's not as nice but loosing the whole images without even knowing is not an option in my opinion. Thanks a lot in advance for implementing this! 👌

chkuendig commented 1 year ago

I just noticed this as well. Image + link would be the better solution for sure.

videah commented 10 months ago

Fixed as of 94370ec, quote posts will render like this when an image is attached, tapping the link will bring you to the original post

IMG_2460