search

video-dev / hls.js

HLS.js is a JavaScript library that plays HLS in browsers with support for MSE.
https://hlsjs.video-dev.org/demo
Other
14.9k stars 2.58k forks source link

Player not able to fallback to stereo for Safari while Dolby is present in the manifest #5524

Closed debjits1 closed 11 months ago

debjits1 commented 1 year ago

What do you want to do with Hls.js?

I am using v1.3.4. I am not sure if it is a bug. Seeing this behavior for manifest with Dolby audio. Ideally it should switch to stereo for Mac OS safari browser. But the player is not doing so. Please suggest some workaround

What have you tried so far?

No response

robwalch commented 1 year ago

Ideally it should switch to stereo for Mac OS safari browser

Why? Based on what information available to the player?

Do you have a sample you can share - Multivariant Playlist or manifest text?

debjits1 commented 1 year ago

@robwalch 

# AUDIO groups
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio-ac-3-384",LANGUAGE="hi",NAME="Hindi",DEFAULT=YES,AUTOSELECT=YES,CHANNELS="6"
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio-aacl-45",LANGUAGE="hi",NAME="Hindi",DEFAULT=YES,AUTOSELECT=YES,CHANNELS="2"
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio-aacl-61",LANGUAGE="hi",NAME="Hindi",DEFAULT=YES,AUTOSELECT=YES,CHANNELS="2"
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio-aacl-93",LANGUAGE="hi",NAME="Hindi",DEFAULT=YES,AUTOSELECT=YES,CHANNELS="2"
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio-aacl-125",LANGUAGE="hi",NAME="Hindi",DEFAULT=YES,AUTOSELECT=YES,CHANNELS="2"
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio-aacl-189",LANGUAGE="hi",NAME="Hindi",DEFAULT=YES,AUTOSELECT=YES,CHANNELS="2"
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio-ec-3-192",LANGUAGE="hi",NAME="Hindi",DEFAULT=YES,AUTOSELECT=YES,CHANNELS="6"

here is the audio group from manifest

Also, I am not exactly sure if it is correct expectation that it should switch to stereo for Mac OS safari browser. Please let me know if there a way we can do that for this manifest

robwalch commented 1 year ago

Ideally it should switch to stereo for Mac OS safari browser. But the player is not doing so.

Desktop macOS can spatialize multi-channel audio on certain hardware so it's not expected that stereo must be selected. It should be pointed out that the Web platform doesn't exactly expose this capability in the most straightforward way. MediaCapabilities can report if multichannel EC-3 with the channels described is supported.

In dev (https://hlsjs-dev.video-dev.org/demo/ v1.5.0-alpha.0 and up) hls.js will use MediaCapabilities to determine if multi-channel audio is supported, but will generally start at stereo and stay there.

Applications will have to select the track manually or provide a hint that multi-channel is preferred (see #5532).

robwalch commented 1 year ago

Marking as answered. Please verify in the latest v1.5 (pre)release.

robwalch commented 11 months ago

Closing as fixed in v1.5.0-beta.1.