search

video-dev / media-ui-extensions

Extending the HTMLVideoElement API to support advanced player user-interface features
MIT License
30 stars 8 forks source link

Prepare repo for writing Proposals #5

Closed gkatsev closed 1 year ago

gkatsev commented 1 year ago

I thought that the current template was more than good enough to start with, though, I added a note to it to mention Goals and Non-Goals. I think we can iterate on the template as we start writing proposals.

Furthermore, I used rust's RFC process for the submitting a proposal step in the README. One thing to point out there is that, similarly to rust's RFC process, I currently have a full 2-week call of consensus to make sure that folks get a chance to review the proposal before it gets merged as ideally, there aren't major changes done to it once it's merged.

The proposals folder has a .gitkeep file to keep the folder around in git. The file can be removed once we merge the first proposal.

I think that Discussions/Issues would be useful to getting to whether something is needed and finding a direction, but that most of the work on proposals should happen in a proposals PR in the future. For example, I think we have more than enough traction in the quality levels issue to start on a proposal. Also, a proposal can be merged before it's implemented in either media-chrome or another Web Component. This is so that we could develop a backlog of proposals, especially if they are well-thought-out, without necessarily require that they are implemented before they are merged.

gkatsev commented 1 year ago

With a brief conversation with @cjpillsbury, I was thinking that maybe it'll be useful to have a base video/media element that serves as the canonical implementation of these media-ui-extensions, an x-video element. This could also serve as a base-class for custom impementations of these. Then, the addition to this current proposal is that after a proposal is merged, it'll be in an "unimplemented" stage and once implemented in x-video, it could move to an implemented/ folder or the stage could be incremented. At that point, the proposal could receive an WebIDL definition. Additionally, x-video could serve as infrastructure for a web-platform-tests type thing for media-ui-extensions.

gkatsev commented 1 year ago

Could use https://github.com/muxinc/custom-video-element as the x-video.

cjpillsbury commented 1 year ago

idea(non-blocking): Currently the readme is very "video player"/"video element"-centric. As a followup effort, we should probably reword this more generically as "media player"/HTMLMediaElement (and then make explicit callouts to audio vs. video where relevant) as an improvement here.

heff commented 1 year ago

This all seems fine to me. @gkatsev want to address some of @cjpillsbury's comments and then we can merge? I think we can clean up language issues and ambiguous things, but probably don't need to stress the exact details too much. I'm sure we'll learn more about what we want as we actually go through the process and we can easily change things as we do.

probably reword this more generically as "media player"

Sounds good to me.

gkatsev commented 1 year ago

Follow-ups: