videoDAC / android

Repository for storing code, configuration and information about the applications developed by videoDAC for Android.
GNU General Public License v3.0
3 stars 5 forks source link

Fix text scaling on Paywall Page for devices with different screen sizes. #28

Closed criticaltv closed 4 years ago

criticaltv commented 4 years ago

Describe the problem

Currently, the paywall page for the Gorli TV app is unable to gracefully scale the font in order to fit conveniently on any size of screen.

Describe your proposed solution

My proposed solution would be to rebuild the software layout for the paywall page to be responsive to the screen's precise dimensions, based on this design:

Screenshot from 2020-02-27 16-09-20

So, in the above image,

Please read the notes in the design, and leave comments below.

Describe other solutions you have considered

A more complex option would be to split the screen like this:

image

Screenshots

For example, this is how it works on a device with 1280x720 screen size (thank you Parth!)

image

It seems to work OK on screens with larger resolution (e.g. on a device with a 2160x1080):

75072546-b0fcee00-551d-11ea-9f43-cfade2a66c98

Specific Deliverables

  1. Please upload screenshot the paywall page loading on devices with at least 4 different screen sizes:
  1. Publish PR with new code to this repository.

  2. Generate new APK file com.videodac.hls and publish in this issue, so that Goerli TV app on Google Play can be updated

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 40.0 LPT (63.2 USD @ $1.58/LPT) attached to it.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Cancelled


Work has been started.

These users each claimed they can complete the work by 2 weeks, 5 days ago. Please review their action plans below:

1) mul1sh has been approved to start work.

Will sort this promptly with an android co-ordinator layout

Learn more on the Gitcoin Issue Details page.

criticaltv commented 4 years ago

Another example

mul1sh commented 4 years ago

New screenshots

640x360 640x360

1280x720 1280x720

2160x1080 2160x1080

3840x2160 / 4k 3840x2160 : 4k

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 40.0 LPT (61.04 USD @ $1.53/LPT) has been submitted by:

  1. @mul1sh

@criticaltv please take a look at the submitted work:


criticaltv commented 4 years ago

Further to some confusion during this bounty being worked on, here are some calculations which will assist in developing this as per the specification:

Let's say the screen size is X by Y.

And let's say that Y < X (although the opposite would still work)

Section 1 (left): Size: X-0.8*Y by Y Top-left corner is at coordinates (0, 0)

Section 2 (top right) is: Size: 0.8*Y by 0.8*Y Top-left corner is at coordinates (X-0.8*Y, 0)

Section 3 (bottom right) is: Size: 0.8*Y by 0.2*Y Top-left corner is at coordinates (X-0.8*Y, 0.8*Y)

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Cancelled


The funding of 40.0 LPT (19.61 USD @ $0.49/LPT) attached to this issue has been cancelled by the bounty submitter