videoDAC / livepeer-aragon

Aragon App for interacting with the Livepeer Protocol. Includes Delegator functionality and basic Transcoder functionality.
https://rinkeby.aragon.org/#/livepeerdelegator.aragonid.eth/0x4a7335f3ecb43b685526c1b39043bf696c78c641
8 stars 2 forks source link

Delegated amount shows 0 if App has not Declared Transcoder #13

Closed chrishobcroft closed 5 years ago

chrishobcroft commented 5 years ago

Current Behaviour

If the App has attracted some stake, but has not called transcoder, the Delegated amount is shown as 0 in the UI.

Expected behaviour

If an App has attracted some Delegated stake, it should show in the app UI.

Screenshots

image

Other notes

This is likely an extreme edge-case, so probably very low priority to fix.

willjgriff commented 5 years ago

I titled it incorrectly. This value is actually the transcoders total stake, which is different from delegated amount. Delegated amount refers to the amount an address has delegated. Total stake is the amount delegated to this address. It is 0 until declared as a transcoder.

willjgriff commented 5 years ago

I've renamed 'Delegated Amount' to 'Total Stake' to hopefully avoid confusion.

chrishobcroft commented 5 years ago

Unfortunately, I expect that the term 'Total Stake' might create more confusion.

To clarify, within Livepeer's protocol, any Ethereum address can have the following two parameters associated with it:

STAKE: this is the amount of stake that has been delegated from this address.

DELEGATED AMOUNT: this is the amount of stake that has been delegated to this address.

Both of these can be non-zero even if the address has not declared as a Transcoder - see screenshot below from Livepeer Explorer (on Rinkeby).

So I would propose that the amount shown in the TRANSCODER tab of the Livepeer Aragon app should be labelled "DELEGATED AMOUNT" (as per the Explorer), and which ought to mirror the information displayed in the explorer, even before the app has declared transcoder (which is currently not the case, as per the original post).

Screenshot from 2019-05-23 10-06-06

willjgriff commented 5 years ago

Fixed as of commit: 25690b4df910570e4a33a0004906d8094fc66559

chrishobcroft commented 5 years ago

Validated as fixed on Rinkeby.