search

videogular / bower-videogular

Bower repository for Videogular project
MIT License
6 stars 23 forks source link

Virtual clip pull request #11

Closed turbidwater closed 8 years ago

turbidwater commented 8 years ago

Hi guys! Thanks for the great library. I've added in the ability to do virtual clips. You can specify a start time and a virtual clip duration to only play a section of a VOD file. By masking the rest of the video users can isolate a clip of a larger media file without having to create another file.

To implement, a user only needs to specify the startTime and virtualClipDuration properties on the config object. If the virtualClipDuration is not specified but startTime is, the video will start playback at the specified startTime, but the video will not be masked to a virtual duration.

Please let me know if you have any questions.

2fdevs commented 8 years ago

First things first. WOW. Awesome work and feature, thank you :)

BUT, I have a big problem here because this repository is only for distribution. So probably I'm going to merge your changes manually if you don't mind.

This is the official repo: https://github.com/2fdevs/videogular

turbidwater commented 8 years ago

That is fine by me. Thanks!

Nils

On Thu, Oct 29, 2015 at 3:20 PM, Two Fucking Developers < notifications@github.com> wrote:

First things first. WOW. Awesome work and feature, thank you :)

BUT, I have a big problem here because this repository is only for distribution. So probably I'm going to merge your changes manually if you don't mind.

— Reply to this email directly or view it on GitHub https://github.com/2fdevs/bower-videogular/pull/11#issuecomment-152331647 .

[ Nils Thingvall | Sr. Developer ] [ RealEyes Media, LLC | www.realeyes.com http://www.realeyesmedia.com/ ] [ 940 Logan Street | Denver CO, 80203 ] [ o. 303.872.0459 ] [ b. h http://www.iheartair.com/ttp://nils.realeyesmedia.com ]

Upcoming Unavailability: November 26, 27 - Thanksgiving Break

2fdevs commented 8 years ago

Hi @turbidwater I've merged all your changes in a new branch. https://github.com/2fdevs/videogular/tree/RC-1.4.0

It's not yet on master but you can take a look to it and even use it. I've fixed some bugs and added a few features.

Thank you for the great feature and work! :)