videogular / bower-videogular

Bower repository for Videogular project
MIT License
6 stars 23 forks source link

Removed dependencies #9

Closed piotrd closed 8 years ago

piotrd commented 9 years ago

Removed angular and angular-sanitize dependencies, as they break building project with Browserify if angular is bundled as a non-npm module (Error: Cannot find module 'angular'). Requiring these doesn't have to occur in a plugin, they are usually required somewhere in the app.

2fdevs commented 8 years ago

Accepted.

Thanks for the suggestion.

whitneyit commented 8 years ago

@2fdevs, Is it possible to look into this again? I think the issue here was that the dependencies were not listed in package.json file.

The above link points to the package.json at the time that this PR was fixing the broken build, and it appears that the breakage may be simply due to browserify not being able to find the modules because they were not installed into the package.json file.

I want to add videogular to the jspm registry via #726 and this is blocking videogular from being added to the registry.

Re: the relevant comment.

piotrd commented 8 years ago

@whitneyit may be right. I took time to test if the removed lines from this PR break the build if I add them back and it looks like all works fine (tested with the latest Browserify).

Elecash commented 8 years ago

Ok, I'm going to add those lines again.

Thanks @whitneyit for the warning and @piotrd for following the conversation :)

Elecash commented 8 years ago

@whitneyit I've updated the latest tag and the master branch.

whitneyit commented 8 years ago

Can these changes also be applied to the other bower repos?

Also, it appears that package.json does not have the dependencies added.

$ npm install --save angular angular-sanitize
Elecash commented 8 years ago

Yeah, sure!

Should we add to other bower repos videogular as a dependency too?

whitneyit commented 8 years ago

Yea that sounds like a good idea!

Elecash commented 8 years ago

Done!

Sorry for taking so long in doing this!

whitneyit commented 8 years ago

All good man thanks!