search

videogular / ngx-videogular

The HTML5 video player for Angular 2 and successor to videogular2
MIT License
126 stars 33 forks source link

ngx-videogular not working with Angular 13 #76

Closed zornic84 closed 2 years ago

zornic84 commented 2 years ago

Good morning,

I want to upgrade from Angular12 to Angular13, but I get the following error message when running "npm update":

npm ERR! Could not resolve dependency: npm ERR! peer @angular/common@">=8.0.0 <13.0.0" from @videogular/ngx-videogular@5.0.0 npm ERR! node_modules/@videogular/ngx-videogular npm ERR! @videogular/ngx-videogular@"^5.0.0" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

IxquitilisSaid commented 2 years ago

Fixed on v5.0.1. Thanks for pointing it out! 😄

akshatrana02 commented 3 months ago

using v5.0.1 getting error Cannot read properties of undefined (reading 'subscriptions') at VgControlsComponent.onPlayerReady (videogular-ngx-videogular-controls.mjs:38:45) at videogular-ngx-videogular-controls.mjs:33:84