videogular / videogular2

The HTML5 video player for Angular 2
https://videogular.github.io/videogular2-showroom/#/
MIT License
672 stars 211 forks source link

Error with cue-points in Edge and IE11 #652

Open GreyingRaven opened 6 years ago

GreyingRaven commented 6 years ago

Description

First of all, great work. this is an amazing app. Cue-Points don't work in MS browsers, they show but it gives errors when adding or removing

Currently using

Expected Behavior

It should work as in other browsers, allowing addition and removal of cue-points

Actual Behavior

When you try to remove a cue-point it gives the following error: ERROR Error: Unexpected call to method or property access.

When you try to add a cue-point it gives the following error: ERROR ReferenceError: 'VTTCue' is undefined

Steps to Reproduce

To reproduce this behavior open the showroom with iExplorer or Edge

  1. Try to add a new cue
  2. Try to remove an existing cue
sliceofbytes commented 5 years ago

The following polyfill will fix the issue for the time being.

window['VTTCue'] = window['VTTCue'] || window['TextTrackCue'];