fix(tests): Update tests for last versions of chrome, minor update to husky

yarres commented 5 years ago

Fix tests for last version of chrome

Update husky pre-commit hook location in package.json as suggested by the authors of this package: husky repository
Update the tests in vg-fullscreen-api.spec.ts to allow successful tests on last version of chrome.
Update version of husky to allow pushing with a node version that use nvm.

BREAKING CHANGE: None that I am aware of;

Checklist

I've read the (contributing)[https://github.com/videogular/videogular2/blob/master/CONTRIBUTING.md] guidelines
Code compiles correctly (run npm start)
Created tests (if necessary)
All tests passing (run npm test)
Extended the README / documentation (if necessary)

Elecash commented 5 years ago

@yarres thank you for your PR.

Can you do it again? You used fix(tests) in your commit message where it should be tests(chrome) or similar.

Changes in tests should not trigger a new release change. So it would be great if you can close this PR and open a new one with the correct commit message.

Thank you.

yarres commented 5 years ago

Ok no problems, I have opened a new one: https://github.com/videogular/videogular2/pull/801

videogular / videogular2

fix(tests): Update tests for last versions of chrome, minor update to husky #799

Checklist