videogular / videogular2

The HTML5 video player for Angular 2
https://videogular.github.io/videogular2-showroom/#/
MIT License
672 stars 211 forks source link

Update to Angular 8 and fix build scripts #834

Closed sliceofbytes closed 5 years ago

sliceofbytes commented 5 years ago

Description

Removed Packages

Added Packages

Updated Packages

Fixes

Linting

Checklist

Please, check that you have been followed next steps:

jderboven commented 5 years ago

Why is it still pending ? ^^

sliceofbytes commented 5 years ago

That's correct the move to angular 8 update is basically just dependencies. I should probably split this into multiple pull requests but I haven't had the time the last couple weeks. I can merge these in if you don't mind having the extra refactoring in the same pull request.

jderboven commented 5 years ago

Of course you can merge with this extra refactoring, I was just wondering whether it had to do with angular 8 problems or not but it did not seem in my opinion, let's merge ? :-)