search

videogular / videogular2

The HTML5 video player for Angular 2
https://videogular.github.io/videogular2-showroom/#/
MIT License
672 stars 211 forks source link

NPM package folder structure broken in 7.0.0 #840

Open sliceofbytes opened 5 years ago

sliceofbytes commented 5 years ago

Description

Latest release breaks expected build folders. Compiled files should output to the base directory for the release. (my fault likely).

Expected Behavior

Compiled file output is the base directory for the npm package.

Actual Behavior

Compiled files are being output in a compiled folder

Attachments

Folder Structure Difference
(https://i.imgur.com/ti5E8Fj.png)
Differences in package layout between 6.4.0 and 7.0.0

Quickfix is to copy the files in the node_modules/videogular2/compiled folder out into the base directory of node_modules/videogular2. I'm still trying to track down the issue. Running npm pack locally gives me the expected output.

I've also confirmed that compiled folder is still included in the .gitignore and the .npmignore

jderboven commented 5 years ago

Hello,

What is the status about this one, maybe we should just move the files then ?

jgbpercy commented 5 years ago

For code consuming the library are we fine to just use import { VgCoreModule } from 'videogular2/compiled/core'; (and similar for other Vg modules)?

Seems to work ok locally, just wondering if there are any caveats to that? If we see issues on our test site I'll update this (although I imagine this might be fixed before we get there).

jderboven commented 5 years ago

@jgbpercy in my opinion it would be better to keep the actual folder structure as is ... Imagine how painful migrating might be for some users

jgbpercy commented 5 years ago

@jgbpercy in my opinion it would be better to keep the actual folder structure as is ... Imagine how painful migrating might be for some users

Yes, I agree. Sorry my reply wasn't clear - I meant if we are using 7.0.0 until the fix is done, will importing from compiled work (temporarily) or are there deeper issues that anyone knows of?