Dash 3.x breaking changes.

rogersnick commented 5 years ago

Description

Upgrading to dash 3.x introduces breaking changes.

Expected Behavior

vg-dash.js should not make a call to setLogToBrowserConsole() since this function does not exist anymore. If we're concerned about backwards compatibility it seems that we can just delete this line since logging to the console is the default behavior.

More deprecated stuff is available here:

https://github.com/Dash-Industry-Forum/dash.js/wiki/Migration-3.0

Actual Behavior

vg-dash.js make a call to this non-existent function, and other things start failing very quickly.

Steps to Reproduce

Install videogular2 (v 7.x)
Install dashjs (v3.x+)
Try to play a video via dash.

Image Title
(https://media.giphy.com/media/2r1AstsjzbeAo/giphy.gif)
The function does not exist!

rogersnick commented 5 years ago

replacing line 70 with this is probably the cooler solution:

this.dash.updateSettings({
        debug: {
          logLevel: dashjs.Debug.LOG_LEVEL_DEBUG
        }
      });

rogersnick commented 2 years ago

closing because well it's been a while, and I'm not able to confirm if this is still an issue

videogular / videogular2