videogular / videogular2

The HTML5 video player for Angular 2
https://videogular.github.io/videogular2-showroom/#/
MIT License
672 stars 211 forks source link

Is videogular2 still being maintained? #872

Open Brhav opened 4 years ago

Brhav commented 4 years ago

The last release is from Jul 25

wayne-optin commented 4 years ago

Work continued after that release - the 'master' was updated as recently as 20 August, but not released.

jinder commented 4 years ago

Looks dead to me. No maintenance of issues, last commit 20 Aug, Angular 9 around the corner which isn't compatible with the current NPM package.

Elecash commented 4 years ago

Sorry guys, I can't get time now to work on it :(

I would love to make it compatible (probably with a fresh start) with Angular 9 and Ivy tho.

GuilhermeBCC commented 4 years ago

if we wait for the angular 9 ... 💀 it looks like it leaves before 2022 😅

sliceofbytes commented 4 years ago

I've got a version that is ready for Ivy and packed as an angular-cli project. I probably won't have time to modify the Travis build and update this repo for at least a few more days. Would you have any time to help me with the Travis CI @EleCash . I've got the working code here if you are interested.

https://github.com/sliceofbytes/ngx-videogular

I would love to move this forward over the next couple weeks if not faster.

Elecash commented 4 years ago

@sliceofbytes I can't this weekend, but I'll try to have some time the next one :)

p3x-robot commented 4 years ago

@sliceofbytes what is this https://github.com/sliceofbytes/ngx-videogular ? is this basically the same as videogular2, but works with Angular 9 and Ivy? Is there a migration or if i use this it will be the same as well?

jinder commented 4 years ago

I've moved to ngx-videogular and it works well. No node restriction and works with ivy out of the box.

p3x-robot commented 4 years ago

i tested it is perfect, thanks!

jdodsoncollins commented 4 years ago

@sliceofbytes are you planning on updating dependencies in your clone and transitioning it into a PR? I am asking since it is not a fork of the main project

I have an incomplete Angular 9-compatible fork running here: https://github.com/hitrecord/videogular2 it is not ready for a PR due to tests but appears to work based my brief manual testing in an Angular 9-based project. This is hosted on https://www.npmjs.com/package/@hitrecord/videogular2 (for now, with our goal of going back to the main branch)

kzimny commented 4 years ago

videogular2 is incompatible with node > 11.0.0:

error videogular2@7.0.1: The engine "node" is incompatible with this module. Expected version ">=10.9.0 <11.0.0". Got "12.16.1"
p3x-robot commented 4 years ago

videogular2 is incompatible with node > 11.0.0:

error videogular2@7.0.1: The engine "node" is incompatible with this module. Expected version ">=10.9.0 <11.0.0". Got "12.16.1"

https://github.com/sliceofbytes/ngx-videogular

kzimny commented 4 years ago

@p3x-robot you asked a very good question, which has not been answered:

Is there a migration or if i use this it will be the same as well?

I'm a bit concerned about the ngx-videogular package because this is not a clone. @Elecash what is your plan?

p3x-robot commented 4 years ago

i use it in a huge video app and no problems at all , i am on 9.0.2 with ivy.

kzimny commented 4 years ago

@sliceofbytes : did you get any answer from @Elecash ? Seems that videogular2 is not mantained anymore. The owner doesn't have time to migrate to v.9.x. Is your goal with ngx-videogular to go back to the main branch of videogular2?

MarioC3 commented 4 years ago

I've got a version that is ready for Ivy and packed as an angular-cli project. I probably won't have time to modify the Travis build and update this repo for at least a few more days. Would you have any time to help me with the Travis CI @Elecash . I've got the working code here if you are interested.

https://github.com/sliceofbytes/ngx-videogular

I would love to move this forward over the next couple weeks if not faster.

Hey Guys! Are you planning on merging these changes into this repo? or can we assume that this project is dead?

Isaac-1010 commented 4 years ago

Hey, yes, I'll get to it as soon as possible.