videogular / videogular2

The HTML5 video player for Angular 2
https://videogular.github.io/videogular2-showroom/#/
MIT License
670 stars 211 forks source link

Videogular2 build does not work anymore #893

Closed Dudedex closed 4 years ago

Dudedex commented 4 years ago

Description

Can not build angular project that uses videogular2 (since today May 13th 2020) (Version 7.0.1)

Expected Behavior

Build should work as before

Actual Behavior

When building with angular cli 8.3.26 the following message shows up

ERROR in node_modules/videogular2/compiled/src/core/vg-media/i-media-element.d.ts(17,27): error TS2304: Cannot find name 'AudioTrackList'. node_modules/videogular2/compiled/src/core/vg-media/i-media-element.d.ts(139,27): error TS2304: Cannot find name 'VideoTrackList'. node_modules/videogular2/compiled/src/core/vg-media/vg-media-element.d.ts(5,27): error TS2304: Cannot find name 'AudioTrackList'. node_modules/videogular2/compiled/src/core/vg-media/vg-media-element.d.ts(42,18): error TS2304: Cannot find name 'VideoTrackList'.

Steps to Reproduce

Remove node_modules => build angular project => error occurs

Elecash commented 4 years ago

:tada: This issue has been resolved in version 7.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Dudedex commented 4 years ago

It also does not work with 7.0.2

still the same error when building with 7.0.2

ERROR in node_modules/videogular2/compiled/src/core/vg-media/i-media-element.d.ts(17,27): error TS2304: Cannot find name 'AudioTrackList'. node_modules/videogular2/compiled/src/core/vg-media/i-media-element.d.ts(139,27): error TS2304: Cannot find name 'VideoTrackList'. node_modules/videogular2/compiled/src/core/vg-media/vg-media-element.d.ts(5,27): error TS2304: Cannot find name 'AudioTrackList'. node_modules/videogular2/compiled/src/core/vg-media/vg-media-element.d.ts(42,18): error TS2304: Cannot find name 'VideoTrackList'.

Elecash commented 4 years ago

Did you tried downloading the project from scratch and doing npm install?

The project works for me.

Dudedex commented 4 years ago

removing the node_modules

and installing it again via npm install => also checked the version in the node_modules folder to be sure that it is the 7.0.2 version

Elecash commented 4 years ago

Try removing also any "metadata" file and package-lock.json, it might have some old dependencies there.

IxquitilisSaid commented 4 years ago

so, it's a rabbit hole but the gist is (the links I'm about to send are in reverse chronological order for a reason):

TL;DR: Don't use TS 3.9.2 for now. Anything below is fine