Closed gkatsev closed 8 years ago
I updated gh-pages to reflect the output of this PR: http://videojs.github.io/font/
LGTM
It seems the scss is now broken. We use the SCSS file in our theme and the CSS output of that is now for example:
.vjs-icon-play {
font-family: VideoJS;
font-weight: normal;
font-style: normal; }
.vjs-icon-play:before {
content: \f101; }
I think it is missing quotes. Should we now also add the adding of quotes manually to our CSS file?
Based on the PR (and other work I've seen linked from the main issue), this was intentional, but confirmed that this output does break things on JSBin. Are we missing something, @gkatsev?
@nickygerritsen yep, it's broken. I'm going to be issuing a patch today that fixes this and creates a new file for people to use to opt into the sass issue
That was also why I ended up holding off from merging the PR to videojs that updated to this version. Expect an update later today.
Ok great! :)
This is because sass translates the codepoints into utf8 characters and it could cause an issue if your browser is interpreting the css as ascii.