videojs / font

Icon font used for Video.js
https://videojs.github.io/font/
Apache License 2.0
60 stars 79 forks source link

don't quote codepoints for sass and then quote them manually #11

Closed gkatsev closed 8 years ago

gkatsev commented 8 years ago

This is because sass translates the codepoints into utf8 characters and it could cause an issue if your browser is interpreting the css as ascii.

gkatsev commented 8 years ago

I updated gh-pages to reflect the output of this PR: http://videojs.github.io/font/

misteroneill commented 8 years ago

LGTM

nickygerritsen commented 8 years ago

It seems the scss is now broken. We use the SCSS file in our theme and the CSS output of that is now for example:

.vjs-icon-play {
  font-family: VideoJS;
  font-weight: normal;
  font-style: normal; }
  .vjs-icon-play:before {
    content: \f101; }

I think it is missing quotes. Should we now also add the adding of quotes manually to our CSS file?

mmcc commented 8 years ago

Based on the PR (and other work I've seen linked from the main issue), this was intentional, but confirmed that this output does break things on JSBin. Are we missing something, @gkatsev?

gkatsev commented 8 years ago

@nickygerritsen yep, it's broken. I'm going to be issuing a patch today that fixes this and creates a new file for people to use to opt into the sass issue

gkatsev commented 8 years ago

That was also why I ended up holding off from merging the PR to videojs that updated to this version. Expect an update later today.

nickygerritsen commented 8 years ago

Ok great! :)