search

videojs / font

Icon font used for Video.js
https://videojs.github.io/font/
Apache License 2.0
60 stars 79 forks source link

Reusable grunt task for plugins #17

Closed thijstriemstra closed 6 years ago

thijstriemstra commented 8 years ago

Plugin authors can add buttons and other elements that contain custom icons. Currently I've copied most of the code in this repository in order to produce a custom font. Is it possible to make a reusable plugin that is also compatible with non-ES6 code? I'm willing to help with a PR but some guidance would be useful.

gkatsev commented 8 years ago

We use webfonts-generator to generate the font files. I'm not sure there's a lot extra stuff in this repo that isn't specific to us. Or do you mean specifically abstracting out the grunt task we use with the webfonts-generator module?

thijstriemstra commented 6 years ago

Perhaps a reusable grunt task is overkill and a custom icons.json should be enough?

I wrote down the steps to update the font for one of my plugins to give you an idea what's required at the moment: https://github.com/collab-project/videojs-record/blob/master/font/README.md

gkatsev commented 6 years ago

Would #24 be sufficient for this?

thijstriemstra commented 6 years ago

@gkatsev yep.