search

videojs / font

Icon font used for Video.js
https://videojs.github.io/font/
Apache License 2.0
60 stars 79 forks source link

make sure update-base64 task can use custom json file #38

Closed thijstriemstra closed 5 years ago

thijstriemstra commented 5 years ago

refs #36

gkatsev commented 5 years ago

Shouldn't custom-json merge into the icon config?

thijstriemstra commented 5 years ago

I have a custom videojs-record-icons.json file and run:

grunt --exclude-default --custom-json=videojs-record-icons.json

The only thing update-base64 needs from the icons.json (or custom-icons.json) is the font name. Merging the font name from custom-icons.json into icons.json is the same as simply picking the name from custom-icons.json, so I chose this approach. The .woff file that the task loads based on the font name has already been generated in a previous step (called generate-font) so no need to merge anything..

thijstriemstra commented 5 years ago

Can this be merged and released? Without this change the --custom-json option is broken..

thijstriemstra commented 5 years ago

ping @gkatsev

gkatsev commented 5 years ago

Thanks for your patience!

gkatsev commented 5 years ago

available in 3.1.1.